Linux preempt-rt

Check our new training course

Real-Time Linux with PREEMPT_RT

Check our new training course
with Creative Commons CC-BY-SA
lecture and lab materials

Bootlin logo

Elixir Cross Referencer

   1
   2
   3
   4
   5
   6
   7
   8
   9
  10
  11
  12
  13
  14
  15
  16
  17
  18
  19
  20
  21
  22
  23
  24
  25
  26
  27
  28
  29
  30
  31
  32
  33
  34
  35
  36
  37
  38
  39
  40
  41
  42
  43
  44
  45
  46
  47
  48
  49
  50
  51
  52
  53
  54
  55
  56
  57
  58
  59
  60
  61
  62
  63
  64
  65
  66
  67
  68
  69
  70
  71
  72
  73
  74
  75
  76
  77
  78
  79
  80
  81
  82
  83
  84
  85
  86
  87
  88
  89
  90
  91
  92
  93
  94
  95
  96
  97
  98
  99
 100
 101
 102
 103
 104
 105
 106
 107
 108
 109
 110
 111
 112
 113
 114
 115
 116
 117
 118
 119
 120
 121
 122
 123
 124
 125
 126
 127
 128
 129
 130
 131
 132
 133
 134
 135
 136
 137
 138
 139
 140
 141
 142
 143
 144
 145
 146
 147
 148
 149
 150
 151
 152
 153
 154
 155
 156
 157
 158
 159
 160
 161
 162
 163
 164
 165
 166
 167
 168
 169
 170
 171
 172
 173
 174
 175
 176
 177
 178
 179
 180
 181
 182
 183
 184
 185
 186
 187
 188
 189
 190
 191
 192
 193
 194
 195
 196
 197
 198
 199
 200
 201
 202
 203
 204
 205
 206
 207
 208
 209
 210
 211
 212
 213
 214
 215
 216
 217
 218
 219
 220
 221
 222
 223
 224
 225
 226
 227
 228
 229
 230
 231
 232
 233
 234
 235
 236
 237
 238
 239
 240
 241
 242
 243
 244
 245
 246
 247
 248
 249
 250
 251
 252
 253
 254
 255
 256
 257
 258
 259
 260
 261
 262
 263
 264
 265
 266
 267
 268
 269
 270
 271
 272
 273
 274
 275
 276
 277
 278
 279
 280
 281
 282
 283
 284
 285
 286
 287
 288
 289
 290
 291
 292
 293
 294
 295
 296
 297
 298
 299
 300
 301
 302
 303
 304
 305
 306
 307
 308
 309
 310
 311
 312
 313
 314
 315
 316
 317
 318
 319
 320
 321
 322
 323
 324
 325
 326
 327
 328
 329
 330
 331
 332
 333
 334
 335
 336
 337
 338
 339
 340
 341
 342
 343
 344
 345
 346
 347
 348
 349
 350
 351
 352
 353
 354
 355
 356
 357
 358
 359
 360
 361
 362
 363
 364
 365
 366
 367
 368
 369
 370
 371
 372
 373
 374
 375
 376
 377
 378
 379
 380
 381
 382
 383
 384
 385
 386
 387
 388
 389
 390
 391
 392
 393
 394
 395
 396
 397
 398
 399
 400
 401
 402
 403
 404
 405
 406
 407
 408
 409
 410
 411
 412
 413
 414
 415
 416
 417
 418
 419
 420
 421
 422
 423
 424
 425
 426
 427
 428
 429
 430
 431
 432
 433
 434
 435
 436
 437
 438
 439
 440
 441
 442
 443
 444
 445
 446
 447
 448
 449
 450
 451
 452
 453
 454
 455
 456
 457
 458
 459
 460
 461
 462
 463
 464
 465
 466
 467
 468
 469
 470
 471
 472
 473
 474
 475
 476
 477
 478
 479
 480
 481
 482
 483
 484
 485
 486
 487
 488
 489
 490
 491
 492
 493
 494
 495
 496
 497
 498
 499
 500
 501
 502
 503
 504
 505
 506
 507
 508
 509
 510
 511
 512
 513
 514
 515
 516
 517
 518
 519
 520
 521
 522
 523
 524
 525
 526
 527
 528
 529
 530
 531
 532
 533
 534
 535
 536
 537
 538
 539
 540
 541
 542
 543
 544
 545
 546
 547
 548
 549
 550
 551
 552
 553
 554
 555
 556
 557
 558
 559
 560
 561
 562
 563
 564
 565
 566
 567
 568
 569
 570
 571
 572
 573
 574
 575
 576
 577
 578
 579
 580
 581
 582
 583
 584
 585
 586
 587
 588
 589
 590
 591
 592
 593
 594
 595
 596
 597
 598
 599
 600
 601
 602
 603
 604
 605
 606
 607
 608
 609
 610
 611
 612
 613
 614
 615
 616
 617
 618
 619
 620
 621
 622
 623
 624
 625
 626
 627
 628
 629
 630
 631
 632
 633
 634
 635
 636
 637
 638
 639
 640
 641
 642
 643
 644
 645
 646
 647
 648
 649
 650
 651
 652
 653
 654
 655
 656
 657
 658
 659
 660
 661
 662
 663
 664
 665
 666
 667
 668
 669
 670
 671
 672
 673
 674
 675
 676
 677
 678
 679
 680
 681
 682
 683
 684
 685
 686
 687
 688
 689
 690
 691
 692
 693
 694
 695
 696
 697
 698
 699
 700
 701
 702
 703
 704
 705
 706
 707
 708
 709
 710
 711
 712
 713
 714
 715
 716
 717
 718
 719
 720
 721
 722
 723
 724
 725
 726
 727
 728
 729
 730
 731
 732
 733
 734
 735
 736
 737
 738
 739
 740
 741
 742
 743
 744
 745
 746
 747
 748
 749
 750
 751
 752
 753
 754
 755
 756
 757
 758
 759
 760
 761
 762
 763
 764
 765
 766
 767
 768
 769
 770
 771
 772
 773
 774
 775
 776
 777
 778
 779
 780
 781
 782
 783
 784
 785
 786
 787
 788
 789
 790
 791
 792
 793
 794
 795
 796
 797
 798
 799
 800
 801
 802
 803
 804
 805
 806
 807
 808
 809
 810
 811
 812
 813
 814
 815
 816
 817
 818
 819
 820
 821
 822
 823
 824
 825
 826
 827
 828
 829
 830
 831
 832
 833
 834
 835
 836
 837
 838
 839
 840
 841
 842
 843
 844
 845
 846
 847
 848
 849
 850
 851
 852
 853
 854
 855
 856
 857
 858
 859
 860
 861
 862
 863
 864
 865
 866
 867
 868
 869
 870
 871
 872
 873
 874
 875
 876
 877
 878
 879
 880
 881
 882
 883
 884
 885
 886
 887
 888
 889
 890
 891
 892
 893
 894
 895
 896
 897
 898
 899
 900
 901
 902
 903
 904
 905
 906
 907
 908
 909
 910
 911
 912
 913
 914
 915
 916
 917
 918
 919
 920
 921
 922
 923
 924
 925
 926
 927
 928
 929
 930
 931
 932
 933
 934
 935
 936
 937
 938
 939
 940
 941
 942
 943
 944
 945
 946
 947
 948
 949
 950
 951
 952
 953
 954
 955
 956
 957
 958
 959
 960
 961
 962
 963
 964
 965
 966
 967
 968
 969
 970
 971
 972
 973
 974
 975
 976
 977
 978
 979
 980
 981
 982
 983
 984
 985
 986
 987
 988
 989
 990
 991
 992
 993
 994
 995
 996
 997
 998
 999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
---------------------
PatchSet 4347 
Date: 2004/08/16 10:29:28
Author: andersen
Branch: HEAD
Tag: busybox_1_00_rc3 
Log:
Prepare for release

Members: 
	Changelog:1.294->1.295 
	docs/busybox_header.pod:1.17->1.18 
	docs/busybox.net/news.html:1.21->1.22 
	docs/busybox.net/screenshot.html:1.11->1.12 

---------------------
PatchSet 4348 
Date: 2004/08/18 17:57:16
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Fixup 'dc' usage

Members: 
	include/usage.h:1.218->1.219 

---------------------
PatchSet 4349 
Date: 2004/08/19 18:22:13
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from Vladimir N. Oleynik:

On Wed Aug 18, 2004 at 06:52:57PM +0800, Matt Johnston wrote:
> I've come across some strange-seeming behaviour when running programs
> under Busybox (1.0.0-rc3) ash. If the child process sets stdin to be
> non-blocking and then exits, the parent ash will also exit. A quick strace
> shows that a subsequent read() from stdin returns EAGAIN (as would be
> expected):

Thanks!
Patch attached.


--w
vodz

Members: 
	shell/ash.c:1.104->1.105 
	shell/cmdedit.c:1.92->1.93 

---------------------
PatchSet 4350 
Date: 2004/08/19 18:25:02
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from Tito documenting the '-q' option

Members: 
	include/usage.h:1.219->1.220 

---------------------
PatchSet 4351 
Date: 2004/08/19 18:26:26
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from Tito adding support for '-q'

Members: 
	procps/kill.c:1.52->1.53 

---------------------
PatchSet 4352 
Date: 2004/08/19 18:30:31
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from Mike Castle to cleanup some modutils issues, in
particular making alias support work better.

Members: 
	modutils/modprobe.c:1.39->1.40 

---------------------
PatchSet 4353 
Date: 2004/08/19 19:15:06
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
regularly update the status line display
 -Erik

Members: 
	editors/vi.c:1.37->1.38 

---------------------
PatchSet 4354 
Date: 2004/08/19 19:17:30
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from Rodney Radford adding x86_64 support.

Members: 
	modutils/insmod.c:1.122->1.123 

---------------------
PatchSet 4355 
Date: 2004/08/25 02:02:19
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch from Manousaridis Angelos to cleanup stale file descriptors, it was preventing unmounting an initial filesystem.

Members: 
	loginutils/getty.c:1.13->1.14 
	loginutils/login.c:1.19->1.20 

---------------------
PatchSet 4356 
Date: 2004/08/26 21:45:21
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Felipe Kellermann writes:

Unfortunatelly I've not followed the last two or three weeks commits (new
semester started and so now I rarely have time to fix my personal bridge)
but tonight I synched my tree and immediately noticed a rather nasty bug!

[Using libbb/interface.c:1.24]
# grep eth0 /proc/net/dev | xargs
eth0:311708397 237346 1670 0 1789 1670 0 0 22580308 120297 0 0 0 102 0 0

# ifconfig eth0
eth0      Link encap:Ethernet  HWaddr 00:20:AF:7C:EA:B7
          inet addr:10.0.0.1  Bcast:10.0.0.127  Mask:255.255.255.128
          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:1000
          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
          Interrupt:5 Base address:0x320


All values `ifconfig' is showing are `zeroed' -- I quickly looked at the
last commits I missed and noticed that there were a commit relating to
ifconfig, libbb/interface.c:1.23->1.24 (PatchSet 4338).

I've reversed the patch and now everything is working again.  I compared
the get_name's return values from the 1.23 and 1.24 and quickly noticed
that the new revision is leaving `p' right on the sep while the rev 1.23
was leaving it right on the starting of the values...

1-line, 1/3-minute patch attached  :-)

Members: 
	libbb/interface.c:1.24->1.25 

---------------------
PatchSet 4357 
Date: 2004/08/26 22:18:56
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Tito writes:

Hi,
I've spent the half night staring at the devilish  my_getpwuid and my_getgrgid functions
trying to find out a way to avoid actual and future potential buffer overflow problems
without breaking existing code.
Finally I've  found a not intrusive way to do this that surely doesn't break existing code
and fixes a couple of problems too.
The attached patch:
1) changes the behaviour of my_getpwuid and my_getgrgid to avoid potetntial buffer overflows
2) fixes all occurences of this function calls in tar.c , id.c , ls.c, whoami.c, logger.c, libbb.h.
3) The behaviour of tar, ls and  logger is unchanged.
4) The behavior of ps with somewhat longer usernames messing up output is fixed.
5) The only bigger change was the increasing of size of the buffers in id.c to avoid
     false negatives (unknown user: xxxxxx) with usernames longer than 8 chars.
     The value i used ( 32 chars ) was taken from the tar header ( see gname and uname).
     Maybe this buffers can be reduced a bit  ( to 16 or whatever ), this is up to you.
6) The increase of size of the binary is not so dramatic:
     size busybox
       text    data     bss     dec     hex filename
     239568    2300   36816  278684   4409c busybox
    size busybox_fixed
       text    data     bss     dec     hex filename
     239616    2300   36816  278732   440cc busybox
7) The behaviour of whoami changed:
    actually it  prints out an username cut down to the size of the buffer.
    This could be fixed by increasing the size of the buffer as in id.c or
    avoid the use of my_getpwuid and use getpwuid directly instead.
    Maybe this colud be also remain unchanged......

Please apply if you think it is ok to do so.
The diff applies on today's cvs tarball (2004-08-25).
Thanks in advance,
Ciao,
Tito

Members: 
	archival/tar.c:1.194->1.195 
	coreutils/id.c:1.24->1.25 
	coreutils/ls.c:1.110->1.111 
	coreutils/whoami.c:1.21->1.22 
	include/libbb.h:1.133->1.134 
	libbb/my_getgrgid.c:1.7->1.8 
	libbb/my_getpwuid.c:1.7->1.8 
	libbb/procps.c:1.13->1.14 
	sysklogd/logger.c:1.39->1.40 

---------------------
PatchSet 4358 
Date: 2004/08/26 22:22:50
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Vladimir N. Oleynik writes:

Ming-Ching,

>>No. Here there are no mistakes.
>>You using POST metod.
>>For get data you should read from stdin CONTENT_LENGTH bytes.

>Hower as I posted a little while ago, there is indeed a bug
>in POST method if the CONTENT_LENGTH is bigger
>than sizeof(wbuf[128]). So if your CGI script is expecting to
>read the full CONTENT_LENGTH, it might block forever,
>because it will only transfer sizeof(wbuf) to the CGI.

Ok, Ok. I should find time to understand with a problem.
Try attached patch.


--w
vodz

Members: 
	networking/httpd.c:1.26->1.27 

---------------------
PatchSet 4359 
Date: 2004/08/26 22:26:26
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Save a line or two

Members: 
	loginutils/getty.c:1.14->1.15 
	loginutils/login.c:1.20->1.21 

---------------------
PatchSet 4360 
Date: 2004/08/26 22:36:02
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Tito writes:

Hi,
I've fixed also the issue of whoami cutting down usernames.
This time I cannot send a diff because i don't know if my previous patches will be applied
or not, so I send in the whole file.
The changes I've made don't affect size but ensure that usernames of whatever lenght
are correctly displayed.
root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami_orig.o
   text    data     bss     dec     hex filename
    102       0       0     102      66 whoami_orig.o
root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami.o
   text    data     bss     dec     hex filename
     93       0       0      93      5d whoami.o

This should be applied even if the other patches aren't as this matches the behaviour of the  GNU whoami.

Thanks in advance,
Ciao,
Tito

Members: 
	coreutils/whoami.c:1.22->1.23 

---------------------
PatchSet 4361 
Date: 2004/08/26 23:01:34
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
The login applet should always be setuid root

Members: 
	include/applets.h:1.114->1.115 

---------------------
PatchSet 4362 
Date: 2004/08/26 23:13:00
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Improve the setuid situation a bit, and make it more apparent
when people really ought to make busybox setuid root.
 -Erik

Members: 
	Makefile:1.296->1.297 
	loginutils/Config.in:1.8->1.9 
	miscutils/Config.in:1.18->1.19 

---------------------
PatchSet 4363 
Date: 2004/08/26 23:15:29
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Togg writes:

Syslogd wont start if remote-logging is enabled and the connection to the
remote-log server is not possible on syslogd startup.

I found a patch somewhere which works like a charm. It uses sendto() which
seems more reliable for this issue.

Please see attached patch. Many people will be more happy with this included
I think.

Regards,
Togg

Members: 
	sysklogd/syslogd.c:1.113->1.114 

---------------------
PatchSet 4364 
Date: 2004/08/27 19:55:28
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Quiet a few warnings

Members: 
	init/mesg.c:1.2->1.3 
	shell/msh.c:1.20->1.21 

---------------------
PatchSet 4365 
Date: 2004/08/28 00:43:05
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Fixup some warnings

Members: 
	archival/bunzip2.c:1.19->1.20 
	archival/libunarchive/decompress_bunzip2.c:1.13->1.14 
	coreutils/uniq.c:1.21->1.22 
	modutils/insmod.c:1.123->1.124 
	networking/ipcalc.c:1.10->1.11 
	util-linux/mkfs_minix.c:1.42->1.43 

---------------------
PatchSet 4366 
Date: 2004/09/02 22:21:39
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Tito writes:

Hi Erik,
Hi to all,
This is part five of the my_get*id story.
I've tweaked a bit this two functions to make them more flexible,
but this changes will not affect existing code.
Now they work so:
1) my_getpwuid( char *user, uid_t uid, int bufsize)

   if bufsize is > 0 char *user cannot be set to NULL
                     on success username is written on static allocated buffer
                     on failure uid as string is written to buffer and NULL is returned
   if bufsize is = 0 char *user can be set to NULL
                     on success username is returned
                     on failure NULL is returned
   if bufsize is < 0 char *user can be set to NULL
                     on success username is returned
                     on failure an error message is printed and the program exits

  2) 1) my_getgrgid( char *group, uid_t uid, int bufsize)

   if bufsize is > 0 char *group cannot be set to NULL
                     on success groupname is written on static allocated buffer
                     on failure gid as string is written to buffer and NULL is returned
   if bufsize is = 0 char *group can be set to NULL
                     on success groupname is returned
                     on failure NULL is returned
   if bufsize is < 0 char *group can be set to nULL
                     on success groupname is returned
                     on failure an error message is printed and the program exits

This changes were needed mainly for my new id applet.
It is somewhat bigger then the previous but matches the behaviour of GNU id
and is capable to handle usernames of whatever length.
BTW: at a first look it seems to me that it will integrate well (with just a few changes)
with the pending patch  in patches/id_groups_alias.patch.
The increase in size is balanced by the removal of my_getpwnamegid.c
from libbb as this was used only in previous id applet and by size optimizations
made possible in whoami.c and in passwd.c.
I know that we are in feature freeze but I think that i've tested it enough
(at least I hope so.......).

Members: 
	coreutils/id.c:1.25->1.26 
	coreutils/whoami.c:1.23->1.24 
	include/libbb.h:1.134->1.135 
	libbb/Makefile.in:1.36->1.37 
	libbb/my_getgrgid.c:1.8->1.9 
	libbb/my_getpwuid.c:1.8->1.9 
	loginutils/passwd.c:1.7->1.8 

---------------------
PatchSet 4367 
Date: 2004/09/02 22:22:16
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Tito writes:

The second patch contains:
1) a size optimization for adduser.c
2) removes a warning about an unused variable in syslogd.c if CONFIG_FEATURE_REMOTE_LOG is not set
3)cosmetic fixes for addgroup_full_usage and adduser_full_usage

Ciao,
Tito

Members: 
	include/usage.h:1.220->1.221 
	loginutils/adduser.c:1.10->1.11 
	sysklogd/syslogd.c:1.114->1.115 

---------------------
PatchSet 4368 
Date: 2004/09/02 23:03:24
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Based on patches from Mike Frysinger, add insmod support for
sparc and ia64 (itanium).

Also, reorganize the insmod architecture support code to be
alphasorted and less messy.

Update the readme to list current insmod arch support.

Members: 
	README:1.35->1.36 
	modutils/insmod.c:1.124->1.125 

---------------------
PatchSet 4369 
Date: 2004/09/02 23:11:52
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
No longer needed

Members: 
	libbb/my_getpwnamegid.c:1.7->1.8(DEAD) 
	patches/id_groups_alias.patch:1.1->1.2(DEAD) 

---------------------
PatchSet 4370 
Date: 2004/09/02 23:13:10
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Jonas Holmberg from axis dot com writes:

This patch makes msh handle variable expansion within backticks more
correctly.

Current behaviour (wrong):
--------------------------

BusyBox v1.00-rc3 (2004.08.26-11:51+0000) Built-in shell (msh)
Enter 'help' for a list of built-in commands.

$ A='`echo hello`'
$ echo $A
`echo hello`
$ echo `echo $A`
hello
$


New behaviour (correct):
------------------------

BusyBox v1.00-rc3 (2004.08.26-11:51+0000) Built-in shell (msh)
Enter 'help' for a list of built-in commands.

$ A='`echo hello`'
$ echo $A
`echo hello`
$ echo `echo $A`
`echo hello`
$

The current behaviour (wrong according to standards) was actually my
fault. msh handles backticks by executing a subshell (which makes it
work on MMU-less systems). Executing a subshell makes it hard to only
expand variables once in the parent. Therefore I export all variables
that will be expanded within the backticks and let the subshell handle
the expansion instead.

The bug was found while searching for security leaks in CGI-scripts.
Current behaviour of msh makes it easy to expand backticks by mistake
in $QUERY_STRING. I recommend appling the patch before release of bb
1.00.

/Jonas

Members: 
	shell/msh.c:1.21->1.22 

---------------------
PatchSet 4371 
Date: 2004/09/08 10:01:07
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patrick Huesmann noticed BusyBox would not link when
CONFIG_FEATURE_COMMAND_EDITING was defined *and*
CONFIG_FEATURE_COMMAND_TAB_COMPLETION was undefined.

Vladimir N. Oleynik writes:

Its declare always, also if CONFIG_FEATURE_COMMAND_TAB_COMPLETION
undefined.
Patch to CVS version attached.

--w
vodz

Members: 
	shell/ash.c:1.105->1.106 

---------------------
PatchSet 4372 
Date: 2004/09/08 10:56:06
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Felipe Kellermann writes:

The Togg's sysklogd patch to use sendto() on remote logging is formatting
strangely (using `<' and '>' surrounding the `msg' string message).  This
is OK, but this is not the standard way of formatting this message.

So this patch does the following:

o Fix the formatting to the standard way.
o Uses `MAXLINE' when needed;
o Don't loop sending messages without a "sleeping time",
  I'm now doing `now = 1', `now <<= 1';
o Don't die on `init_RemoteLog' when starting up (feature!)
  We're now trying to connect every time we have an invalid fd;
o Removes one static uneeded variable.
o Removes two automatic uneeded variables.

Members: 
	sysklogd/syslogd.c:1.115->1.116 

---------------------
PatchSet 4373 
Date: 2004/09/08 20:13:05
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Fixup URL

Members: 
	docs/busybox.net/cvs_write.html:1.9->1.10 

---------------------
PatchSet 4374 
Date: 2004/09/14 13:59:44
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
I have to assume both Avaks and LSILogic are deliberatly ignoring me.

Members: 
	docs/busybox.net/shame.html:1.18->1.19 

---------------------
PatchSet 4375 
Date: 2004/09/14 16:08:02
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch from tito to add argument checking.

Members: 
	loginutils/addgroup.c:1.12->1.13 

---------------------
PatchSet 4376 
Date: 2004/09/14 16:23:56
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch from Felipe Kellermann, adds missing applet usage options, removes usage
for options that are currently not implemented and fixes typos.

Members: 
	include/usage.h:1.221->1.222 

---------------------
PatchSet 4377 
Date: 2004/09/14 17:24:58
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch from Felipe Kellermann, remove some unnecessary dups, i declared a few extra const's also.

Members: 
	networking/ifupdown.c:1.50->1.51 
	networking/telnet.c:1.43->1.44 
	networking/telnetd.c:1.12->1.13 
	networking/tftp.c:1.28->1.29 
	util-linux/getopt.c:1.13->1.14 

---------------------
PatchSet 4378 
Date: 2004/09/14 18:12:13
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch by Felipe Kellermann, fix a bug introduced in the last patch by adding a condition around the remote logging, also adds some comments.

Members: 
	sysklogd/syslogd.c:1.116->1.117 

---------------------
PatchSet 4379 
Date: 2004/09/14 18:56:52
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Apply patch from Felipe Kellermann to simlify logic of sort functions.
I reversed the result of the sort functions to make the big numbers go to the top.

Members: 
	procps/top.c:1.12->1.13 

---------------------
PatchSet 4380 
Date: 2004/09/14 19:14:00
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
remove a cut/paste mistake, i better get some sleep.

Members: 
	procps/top.c:1.13->1.14 

---------------------
PatchSet 4381 
Date: 2004/09/15 02:05:23
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch by Felipe Kellermann, use the common escape handling function and remove some unused code.

Members: 
	coreutils/printf.c:1.22->1.23 

---------------------
PatchSet 4382 
Date: 2004/09/15 02:39:09
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Only write to shadow file is shadow passwords are enabled. Patch by magicfox modified by myself to retain check for shadow file access.

Members: 
	loginutils/passwd.c:1.8->1.9 

---------------------
PatchSet 4383 
Date: 2004/09/15 03:04:07
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Tito writes,
"This patch fixes all the bugs in id previously spotted by vodz and me.
The binary size increased a bit,  but now it should work as expected."

Members: 
	coreutils/id.c:1.26->1.27 
	include/libbb.h:1.135->1.136 
	libbb/Makefile.in:1.37->1.38 
	libbb/my_getgrgid.c:1.9->1.10 
	libbb/my_getpwuid.c:1.9->1.10 
	libbb/my_getug.c:INITIAL->1.1 

---------------------
PatchSet 4384 
Date: 2004/09/15 03:24:32
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Add a missing brace, patch by Hideki IWAMOTO

Members: 
	coreutils/stty.c:1.9->1.10 

---------------------
PatchSet 4385 
Date: 2004/09/23 20:08:46
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Add some notes on how to make telnetd actually work

Members: 
	networking/Config.in:1.28->1.29 

---------------------
PatchSet 4386 
Date: 2004/09/24 01:25:39
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
A bit of extra explanation regarding STANDALONE

Members: 
	shell/Config.in:1.16->1.17 

---------------------
PatchSet 4387 
Date: 2004/09/24 02:04:13
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch from David Daney to make the -i option work with -l.

Members: 
	coreutils/ls.c:1.111->1.112 

---------------------
PatchSet 4388 
Date: 2004/09/24 02:36:44
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Remove this error message at Vodz request, it was misleading.

Members: 
	libbb/correct_password.c:1.4->1.5 

---------------------
PatchSet 4389 
Date: 2004/09/24 09:09:44
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Fix a typo

Members: 
	shell/Config.in:1.17->1.18 

---------------------
PatchSet 4390 
Date: 2004/09/24 09:18:55
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch from Egor Duda
Attached patch prevents modprobe from trying to call 'insmod (null)'
whenever nonexistent module is either passed to modprobe via command
line or mentioned in modules.dep

this replaces cryptic error
sh: Syntax error: word unexpected (expecting ")")
with
modprobe: module some-module not found.

egor.

Members: 
	modutils/modprobe.c:1.40->1.41 

---------------------
PatchSet 4391 
Date: 2004/09/24 09:24:27
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch from Dmitry Zakharov to fix a bug triggered by freeswan's scripts.

Members: 
	editors/awk.c:1.10->1.11 

---------------------
PatchSet 4392 
Date: 2004/09/30 00:24:21
Author: bug1
Branch: HEAD
Tag: (none) 
Log:
Patch from William Barsse to fix a segfault when multiple files are specified.

Members: 
	coreutils/tail.c:1.47->1.48 

---------------------
PatchSet 4393 
Date: 2004/10/07 00:35:59
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Make it more apparent that archive creation is not supported

Members: 
	archival/ar.c:1.49->1.50 

---------------------
PatchSet 4394 
Date: 2004/10/08 07:21:58
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from Michael Tokarev:

Scenario:

  touch x -- creates plain file name `x'
  mkdir x -- exits successefully

libbb/make_directory.c, bb_make_directory(), contains
the following code:

        if (mkdir(path, 0777) < 0) {
            /* If we failed for any other reason than the directory
             * already exists, output a diagnostic and return -1.*/
            if (errno != EEXIST) {
                fail_msg = "create";
                umask(mask);
                break;
            }
            /* Since the directory exists, don't attempt to change
             * permissions if it was the full target.  Note that
             * this is not an error conditon. */
            if (!c) {
                umask(mask);
                return 0;
            }
        }

The assumption that EEXIST error is due to that the *directory*
already exists is wrong: any file type with that name will cause
this error to be returned.  Proper way IMHO will be is to stat()
the path and check whenever this is really a directory.  Below
(attached) is a patch to fix this issue.

Members: 
	libbb/make_directory.c:1.15->1.16 

---------------------
PatchSet 4395 
Date: 2004/10/08 07:45:08
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
egor duda writes:

Hi!

I've created a patch to busybox' build system to allow building it in
separate tree in a manner similar to kbuild from kernel version 2.6.

That is, one runs command like
'make O=/build/some/where/for/specific/target/and/options'
and everything is built in this exact directory, provided that it exists.

I understand that applyingc such invasive changes during 'release
candidates' stage of development is at best unwise. So, i'm currently
asking for comments about this patch, starting from whether such thing
is needed at all to whether it coded properly.

'make check' should work now, and one make creates Makefile in build
directory, so one can run 'make' in build directory after that.

One possible caveat is that if we build in some directory other than
source one, the source directory should be 'distclean'ed first.

egor

Members: 
	Makefile:1.297->1.298 
	Rules.mak:1.37->1.38 
	applets/Makefile:1.5->1.6 
	applets/Makefile.in:1.5->1.6 
	archival/Makefile:1.7->1.8 
	archival/Makefile.in:1.5->1.6 
	archival/libunarchive/Makefile:1.5->1.6 
	archival/libunarchive/Makefile.in:1.23->1.24 
	console-tools/Makefile:1.4->1.5 
	console-tools/Makefile.in:1.5->1.6 
	coreutils/Makefile:1.3->1.4 
	coreutils/Makefile.in:1.9->1.10 
	coreutils/libcoreutils/Makefile:1.3->1.4 
	coreutils/libcoreutils/Makefile.in:1.3->1.4 
	debianutils/Makefile:1.3->1.4 
	debianutils/Makefile.in:1.5->1.6 
	editors/Makefile:1.4->1.5 
	editors/Makefile.in:1.5->1.6 
	findutils/Makefile:1.4->1.5 
	findutils/Makefile.in:1.4->1.5 
	init/Makefile:1.5->1.6 
	init/Makefile.in:1.9->1.10 
	libbb/Makefile:1.10->1.11 
	libbb/Makefile.in:1.38->1.39 
	libpwdgrp/Makefile:1.3->1.4 
	libpwdgrp/Makefile.in:1.4->1.5 
	loginutils/Makefile:1.3->1.4 
	loginutils/Makefile.in:1.8->1.9 
	miscutils/Makefile:1.7->1.8 
	miscutils/Makefile.in:1.12->1.13 
	modutils/Makefile:1.4->1.5 
	modutils/Makefile.in:1.3->1.4 
	networking/Makefile:1.7->1.8 
	networking/Makefile.in:1.19->1.20 
	networking/libiproute/Makefile:1.3->1.4 
	networking/libiproute/Makefile.in:1.6->1.7 
	networking/udhcp/Makefile:1.3->1.4 
	networking/udhcp/Makefile.in:1.10->1.11 
	procps/Makefile:1.4->1.5 
	procps/Makefile.in:1.6->1.7 
	scripts/config/Makefile:1.4->1.5 
	shell/Makefile:1.4->1.5 
	shell/Makefile.in:1.3->1.4 
	sysklogd/Makefile:1.5->1.6 
	sysklogd/Makefile.in:1.3->1.4 
	testsuite/runtest:1.8->1.9 
	testsuite/du/du-h-works:1.1->1.2 
	testsuite/du/du-k-works:1.1->1.2 
	testsuite/du/du-l-works:1.1->1.2 
	testsuite/du/du-m-works:1.1->1.2 
	testsuite/du/du-s-works:1.1->1.2 
	testsuite/du/du-works:1.1->1.2 
	testsuite/head/head-n-works:1.1->1.2 
	testsuite/head/head-works:1.1->1.2 
	testsuite/ls/ls-1-works:1.1->1.2 
	testsuite/ls/ls-h-works:1.1->1.2 
	testsuite/ls/ls-l-works:1.1->1.2 
	testsuite/ls/ls-s-works:1.1->1.2 
	testsuite/sort/sort-n-works:1.1->1.2 
	testsuite/sort/sort-r-works:1.1->1.2 
	testsuite/sort/sort-works:1.1->1.2 
	testsuite/tail/tail-n-works:1.1->1.2 
	testsuite/tail/tail-works:1.1->1.2 
	testsuite/xargs/xargs-works:1.1->1.2 
	util-linux/Makefile:1.6->1.7 
	util-linux/Makefile.in:1.8->1.9 

---------------------
PatchSet 4396 
Date: 2004/10/08 07:58:30
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
As noticed by egor duda, current_menu is declared as 'extern struct menu
*current_menu;' in scripts/config/lkc.h line 63, and this conflicts with
static definition in mconf.c.

Members: 
	scripts/config/mconf.c:1.5->1.6 

---------------------
PatchSet 4397 
Date: 2004/10/08 08:03:29
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
last_patch139.gz from Vladimir N. Oleynik:

>I also don't mean to disagree about leaving 30x status codes until after
>1.0.  In fact, although redirecting http://host/dir to http://host/dir/
>with a 301 is common practice (e.g. Apache, IIS), AFAIK it isn't
>actually required (or mentioned) by the HTTP specs.

Ok.
Attached patch have 302 and 408 implemented features.


--w
vodz

Members: 
	networking/httpd.c:1.27->1.28 

---------------------
PatchSet 4398 
Date: 2004/10/08 08:07:40
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Tito writes:

Hi to all,
This patch contains just some fixes for some misleading
comments in my_getpwuid.c and my_getug.c.
The code is untouched so this patch will not
cause troubles.

Please apply.

Thanks in advance and Ciao,
Tito

Members: 
	libbb/my_getpwuid.c:1.10->1.11 
	libbb/my_getug.c:1.1->1.2 

---------------------
PatchSet 4399 
Date: 2004/10/08 08:10:57
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Hiroshi Ito writes:

    Hello

    I'm using busy box on mipsel machine.

    "grep -f file" will cause segmentation fault.

Vladimir N. Oleynik writes:

Hiroshi,

Thank for bug report, but your patch is full broken.
Worked patch attached.
(really changes is zero initialize, and indent correcting).


--w
vodz

Members: 
	findutils/grep.c:1.85->1.86 

---------------------
PatchSet 4400 
Date: 2004/10/08 08:14:58
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Hiroshi Ito writes:

ash
   "unset OLDPWD; cd -"  causes segmentation fault.
    ( OLDPWD is not set when sh is invoked from getty. )

patch against current CVS is attached.

Members: 
	shell/ash.c:1.106->1.107 

---------------------
PatchSet 4401 
Date: 2004/10/08 08:17:39
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Hiroshi Ito writes:

"kill -HUP 1" reloads inittab, and when I append one line to inittab
and send HUP signal two times, It will starts 2 process.

patch against current CVS is attached.

Members: 
	init/init.c:1.204->1.205 

---------------------
PatchSet 4402 
Date: 2004/10/08 08:21:54
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Hiroshi Ito writes:

Hello, all.

Busybox init does not handle removed inittab entry correctly.

# I'm sorry about my poor english, but you can find
# what I would like to say from patch, isn't it?

even if you apply this path,
when yoy try to change a command line option in inittab,
you have to do following steps.
1. remove old line from initrd
2. send HUP signal to init
3. kill old proces which is invoked from init.
4. append new line to inittab
5. send HUP signal to init, again

patch is against current CVS + last patch witch I send it last.

Members: 
	init/init.c:1.205->1.206 

---------------------
PatchSet 4403 
Date: 2004/10/08 08:27:40
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from Denis Vlasenko to fix a problem where
wget http://1.2.3.4/abc/ loses last '/'

Members: 
	networking/wget.c:1.74->1.75 

---------------------
PatchSet 4404 
Date: 2004/10/08 08:49:25
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Wade Berrier writes:

Hello,

Here's a patch for a first attempt at static leases for udhcpd.
Included in the tarball are 2 files (static_leases.c, static_leases.h)
and a patch against the latest cvs.

In the config file you can configure static leases with the following
format:

static_lease 00:60:08:11:CE:4E 192.168.0.54
static_lease 00:60:08:11:CE:3E 192.168.0.44

Comments/suggestions/improvements are welcome.


Wade

Members: 
	examples/udhcp/udhcpd.conf:1.3->1.4 
	networking/udhcp/Makefile.in:1.11->1.12 
	networking/udhcp/dhcpd.c:1.6->1.7 
	networking/udhcp/dhcpd.h:1.6->1.7 
	networking/udhcp/files.c:1.14->1.15 
	networking/udhcp/leases.c:1.6->1.7 
	networking/udhcp/serverpacket.c:1.6->1.7 
	networking/udhcp/static_leases.c:INITIAL->1.1 
	networking/udhcp/static_leases.h:INITIAL->1.1 

---------------------
PatchSet 4405 
Date: 2004/10/08 08:57:35
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from Claus Klein to increase, and make more apparent
the hard coded limit on the number of mounts

Members: 
	libbb/mtab.c:1.5->1.6 

---------------------
PatchSet 4406 
Date: 2004/10/08 09:43:34
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Fix CONFIG_ASH_MATH_SUPPORT_64 so it actually works

Members: 
	shell/ash.c:1.107->1.108 

---------------------
PatchSet 4407 
Date: 2004/10/08 10:50:08
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Add an initial FAQ

Members: 
	docs/busybox.net/FAQ.html:INITIAL->1.1 
	docs/busybox.net/header.html:1.8->1.9 

---------------------
PatchSet 4408 
Date: 2004/10/08 10:52:08
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Fix the supported architectures section

Members: 
	README:1.36->1.37 

---------------------
PatchSet 4409 
Date: 2004/10/08 10:52:33
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Bump version

Members: 
	Rules.mak:1.38->1.39 

---------------------
PatchSet 4410 
Date: 2004/10/08 10:54:20
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
unmerged fix

Members: 
	docs/busybox.net/news.html:1.22->1.23 

---------------------
PatchSet 4411 
Date: 2004/10/08 11:11:02
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
oops

Members: 
	docs/busybox.net/FAQ.html:1.1->1.2 

---------------------
PatchSet 4412 
Date: 2004/10/11 20:52:16
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Patch from David Daney:

It seems that date  -s MMDDHHMMYYYY.ss

will ignore the .ss part.  This patch tries to fix the problem.

David Daney.

Members: 
	coreutils/date.c:1.47->1.48 

---------------------
PatchSet 4413 
Date: 2004/10/13 06:25:51
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Make certain clients of bb_make_directory default to honoring
the user's umask

Members: 
	archival/libunarchive/data_extract_all.c:1.20->1.21 
	libbb/make_directory.c:1.16->1.17 
	miscutils/devfsd.c:1.9->1.10 

---------------------
PatchSet 4414 
Date: 2004/10/13 07:18:05
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
Simon Poole writes:

Erik,

Attached is a patch for the udhcpc sample scripts, to correct the order in
which routers are applied if the DHCP server provides more than one (as per
section 3.5 of RFC2132).

Apologies for not being on the mailing list and thanks for your continued
efforts.

Simon.

Members: 
	examples/udhcp/sample.bound:1.1->1.2 
	examples/udhcp/sample.renew:1.1->1.2 
	examples/udhcp/simple.script:1.1->1.2 

---------------------
PatchSet 4415 
Date: 2004/10/13 07:25:01
Author: andersen
Branch: HEAD
Tag: (none) 
Log:
return failure when nslookup fails

Members: 
	networking/nslookup.c:1.32->1.33